Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBPIH-5342 Fix HelpScout not opening when changing locales #3801

Conversation

drodzewicz
Copy link
Collaborator

No description provided.

@drodzewicz drodzewicz self-assigned this Jan 26, 2023
@drodzewicz
Copy link
Collaborator Author

After investigating this issue it appeared to be that the fault of it was that there were two instances of <HelpScout /> being rendered at the same time.
During one of the previous releases when I was working on the collapsible mobile menu I went with the approach of rendering all of the navItems in the megamenu twice (one for default megamenu and another for mobile collapsible) and hide/show them using bootstrap breakpoint classes like d-md-none.
Since these navbarItems were hidden using classes that meant that they are still available in the DOM hence why there were two insatnces of the <HelpScout /> button.
With my current solution all I do is instead of hiding these navbarItems using classes I use javascript instead which removes these elements from the DOM.

@drodzewicz
Copy link
Collaborator Author

The NavbarIcons.jsx file looks like it has a lot of changes starting on this line but actually I just wrapped these elements in braces with isMenuCollapsed && to render the appropriate navitems

@drodzewicz drodzewicz force-pushed the OBPIH-5342-help-panel-doesnt-open-after-changing-locale branch 2 times, most recently from 28e33e5 to 2918b7f Compare January 26, 2023 14:07
@awalkowiak awalkowiak merged commit 24accb6 into release/0.8.21 Jan 26, 2023
@awalkowiak awalkowiak deleted the OBPIH-5342-help-panel-doesnt-open-after-changing-locale branch January 26, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants