OBPIH-5802 Fetch users based on role in fulfilling location #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchelstowski
approved these changes
Sep 19, 2023
|
@kchelstowski disregard the previous comment I was thinking about a different thing, but yes you are right, array is a truth value. |
awalkowiak
approved these changes
Sep 19, 2023
awalkowiak
deleted the
OBPIH-5802-select-approver-in-create-request-approvals-end-to-end-workflow
branch
awalkowiak
pushed a commit
that referenced
this pull request
Oct 26, 2023
* OBPIH-5802 Fix select tooltip showing up on empty multiselect * OBPIH-5802 Fetch user list of approvers based on desnation location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add the location parameter on the frontend when fetching approvers based on location roles.
Additionally fixed the multi-select tooltip, which was showing up because it's value is anArrayinstead of simple[].When casting an
Array(0)to abooleanit returnstrueunlike casting a[]which returnsfalseAdditionally fixed the multi-select tooltip, which was showing up because it's value is an array which is a truthy even when it is empty.