OBPIH-5873 Investigate empty date approved after approval action #4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alannadolny
requested review from
jmiranda,
awalkowiak,
drodzewicz and
kchelstowski
kchelstowski
reviewed
Oct 4, 2023
| } | ||
| requisition.save(flush: true) |
There was a problem hiding this comment.
I think we should get rid of one of the saves - either this one or the one in the transitionRequisitionStatus.
If removing the flush won't cause any problems with the event that is published after this method is called, we could remove this save in my opinion.
| import org.springframework.context.ApplicationEvent | ||
|
|
||
| class RequisitionStatusTransitionEvent extends ApplicationEvent { | ||
| Requisition requisition | ||
|
|
||
| User createdBy | ||
| RequisitionStatus status |
There was a problem hiding this comment.
is it necessary? Can't you get it from the requisition?
There was a problem hiding this comment.
Yeah, I thought we were going to do this synchronously to have a valid status on the requisition...
alannadolny
force-pushed
the
OBPIH-5873
branch
3 times, most recently
from
37119b9
to
bc1844c
Compare
awalkowiak
approved these changes
Oct 5, 2023
kchelstowski
approved these changes
Oct 5, 2023
| requisitionService.triggerRequisitionStatusTransition(requisition, event.createdBy) | ||
| notificationService.publishRequisitionStatusTransitionNotifications(requisition) | ||
| } | ||
| notificationService.publishRequisitionStatusTransitionNotifications(event.requisition) |
There was a problem hiding this comment.
the indent feels too big, doesn't it?
alannadolny
force-pushed
the
OBPIH-5873
branch
from
bc1844c
to
7a50cf3
Compare
awalkowiak
pushed a commit
that referenced
this pull request
Oct 26, 2023
* OBPIH-5873 Make status transition synchronous and pass status as an argument * OBPIH-5873 Fix passing status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.