OBPIH-5825 Add comments count on comments tab #4325
Conversation
drodzewicz
commented
Oct 10, 2023
drodzewicz
commented
- add comment count badge
- sort comments desc by last updated
- show comments only on requests (check by SourceType == Electronic)
- add comment count badge - sort comments desc by last updated - show comments only on requests (check by SourceType == Electronic)
| @@ -12,7 +12,7 @@ | |||
| </tr> | |||
| </thead> | |||
| <tbody> | |||
| <g:each var="comment" in="${requisition?.comments}"> | |||
| <g:each var="comment" in="${requisition?.comments?.sort(){ a,b -> b?.lastUpdated <=> a?.lastUpdated }}"> | |||
There was a problem hiding this comment.
Maybe we can create a method for comparing lastUpdated dates in the domain, and use the .sort() method without passing closure?
There was a problem hiding this comment.
I'd suggest maybe just overriding compareTo method in Comment domain and just use .sort(), but it's optional.
There was a problem hiding this comment.
Just like Kacper suggested, I'll overwrite compareTo and call sort() in the GSP.
| <g:link controller="stockMovement" action="comments" params="${[ id: stockMovement?.id ]}"> | ||
| <warehouse:message code="comments.label" default="Comments"/> | ||
| <warehouse:message code="comments.label" default="Comments"/>${fragment} |
There was a problem hiding this comment.
what is ${fragment}?
There was a problem hiding this comment.
I was testing how to extract # from the URL, but it didn't. Thanks for noticing that, it needs to be removed.
| @@ -12,7 +12,7 @@ | |||
| </tr> | |||
| </thead> | |||
| <tbody> | |||
| <g:each var="comment" in="${requisition?.comments}"> | |||
| <g:each var="comment" in="${requisition?.comments?.sort(){ a,b -> b?.lastUpdated <=> a?.lastUpdated }}"> | |||
There was a problem hiding this comment.
I'd suggest maybe just overriding compareTo method in Comment domain and just use .sort(), but it's optional.
| @@ -28,7 +29,7 @@ | |||
| <g:if test="${stockMovement?.documents}"> | |||
| <div class="right"> | |||
| <div class="button-group"> | |||
| <g:if test="${stockMovement?.requisition}"> | |||
| <g:if test="${stockMovement.sourceType == RequisitionSourceType.ELECTRONIC}"> | |||
There was a problem hiding this comment.
I assume it's only a regression fix?
There was a problem hiding this comment.
more like an oversight on my part
There was a problem hiding this comment.
You can use stockMovement.electronicType
| @@ -28,7 +29,7 @@ | |||
| <g:if test="${stockMovement?.documents}"> | |||
| <div class="right"> | |||
| <div class="button-group"> | |||
| <g:if test="${stockMovement?.requisition}"> | |||
| <g:if test="${stockMovement.sourceType == RequisitionSourceType.ELECTRONIC}"> | |||
There was a problem hiding this comment.
You can use stockMovement.electronicType
| @@ -555,10 +556,14 @@ | |||
| <warehouse:message code="documents.label" default="Documents"/> | |||
| </g:link> | |||
| </li> | |||
| <g:if test="${stockMovement?.requisition}"> | |||
| <li> | |||
| <g:if test="${stockMovement.sourceType == RequisitionSourceType.ELECTRONIC}"> | |||
* OBPIH-5825 Add comments count on comments tab - add comment count badge - sort comments desc by last updated - show comments only on requests (check by SourceType == Electronic) * OBPIH-5825 Overwrite compareTo on Comment
