OBPIH-5771 Fix ordering by year on requisition by year indicator #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchelstowski
approved these changes
Oct 23, 2023
| } | ||
| results = results.sort() |
There was a problem hiding this comment.
out of curiosity - what is it sorted by? I ask, because I don't see what type is hidden under the results
There was a problem hiding this comment.
@kchelstowski expand code a little bit and you'll see it
There was a problem hiding this comment.
results is of type LinkedHashMap, apparently by default it sorts its values by keys
awalkowiak
approved these changes
Oct 24, 2023
awalkowiak
deleted the
OBPIH-5771-invalid-order-of-data-on-requisition-count-by-year-indicator
branch
awalkowiak
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.