OBPIH-6045 Updated openboxes.dbml file using schema-export and sql2db… #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no need to comment on the PR, but I've added you as reviewers to brainstorm what we can do to automate the process documented in #4094. I don't want to automate committing changes to the dbml file here in the repo. I'd rather export that to GH packages or some temporary file store and then have github actions pull that artifact when running dbdocs. |
EWaterman
approved these changes
May 8, 2024
jmiranda
commented
May 9, 2024
| Table "address" { | ||
| "id" char(38) [pk, not null, default: ""] | ||
| "version" bigint(20) [not null] | ||
| "id" varchar(255) [pk, not null] |
There was a problem hiding this comment.
Bummer. I just noticed that Hibernate's schema-export does do exactly what our database migrations do, so I'm going to need to run the migrations (maybe on a testcontainer) and then use mysqldump to get a more precise DDL file to convent to DBML.
awalkowiak
changed the base branch from
feature/upgrade-to-grails-3.3.10
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ml (see #4094)