Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #17 and README updates #23

Closed
wants to merge 8 commits into from
Closed

Fix for issue #17 and README updates #23

wants to merge 8 commits into from

Conversation

schevalia
Copy link

@schevalia schevalia commented Nov 23, 2019

Closes #17

@chrisjm
Copy link
Collaborator

chrisjm commented Nov 25, 2019

Heya @schevalia ! Thanks for opening this PR!

This week is going to be busy with the holiday, but I will be sure to review this more in-depth next week.

🍻

@chrisjm chrisjm mentioned this pull request Dec 17, 2019
1 task
@chrisjm
Copy link
Collaborator

chrisjm commented Dec 17, 2019

Hi, @schevalia ! Sorry for the massive delay in getting back to you regarding this PR.

I realized that removing the import task before writing a new task may be jumping the gun a little :)

I created a new issue (#27) to handle this. Once that's complete, we can merge this one. Hopefully I can hammer that out soon.

@chrisjm chrisjm added the on hold Issue or PR is on hold or blocked label Dec 17, 2019
@chrisjm
Copy link
Collaborator

chrisjm commented Jun 8, 2021

Closed by #68 . Sorry for the miscommunication on this one @schevalia 🍻

@chrisjm chrisjm closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Issue or PR is on hold or blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Brewers Association import task
2 participants