Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a user ID paramter to services/caches/map/tile to query other users' maps #496

Closed
following5 opened this issue Sep 1, 2017 · 3 comments · Fixed by opencaching/opencaching-pl#1762

Comments

@following5
Copy link
Contributor

In OCPL code there is the feature to view another user's map. This feature is used to plan common geocaching trips (see opencaching/opencaching-pl#1169).

To accomplish this, OCPL code makes the user who views the map prentend to be someone else. Wrygiel wrote in issue #439:

So, whenever Facade::service_call is called with non-null user_id, OKAPI assumes that it is this user_id who called it. However, in case of OCPL's feature of "peeking at other user's map", this is not true.

So, I believe we have two problems here:

  • OCPL doesn't properly state that it is not the user who is making this call.
  • OKAPI doesn't allow OCPL to state the above.

This may be solved by adding a User ID to services/caches/map/tile. Then it must be determined which data of this user may be accessed by another user and which shall not be published (e.g. the information about what caches are ignored).

@following5
Copy link
Contributor Author

This is a good lot of work, but it's important. Faking user identities is not safe. Privacy leaks can be introduced easily.

First we need to clarify the ignore thing.

@kojoty @harrieklomp @andrixnet: Do you want that the "cache is ignored" information stays public? Currently everyone can find out what caches any user ignores, by showing the other user's map.

@kojoty
Copy link
Member

kojoty commented Nov 16, 2018

hmm.. I'm not sure if we need to treat ignores as something private - I just ignore caches which I don't want to search to clean up the map - there is anything private in it - for me...

Anyway noone ask for hide this.

My opinion is to stay with it as is. If anyone will request such change we can come back to this discussion.

@following5
Copy link
Contributor Author

My opinion is to stay with it as is. If anyone will request such change we can come back to this discussion.

That sounds to me like a good and easy solution to start with. I was thinking too complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants