Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid link in OC Team comments #934

Open
deg-pl opened this issue Mar 26, 2017 · 5 comments
Open

Invalid link in OC Team comments #934

deg-pl opened this issue Mar 26, 2017 · 5 comments

Comments

@deg-pl
Copy link
Member

deg-pl commented Mar 26, 2017

When OC Team accept cache, system adds a comment that Cache is accepted by OC Team. Comment has link to /viewprofile.php?userid=0 which doesn't work.
tmp
We should remove this link or change link to i.e. Wiki page about OC Team (or any other solution ;) ).

(from forum: https://forum.opencaching.pl/viewtopic.php?p=136971#p136971)
Also related with #809

@harrieklomp
Copy link
Member

Is it not possible to make user "oc-team" with ID 0? Or if there is already a user "oc-team" there could via settings file link to that account.
In DB there is also a user "System" with ID -1

@andrixnet
Copy link
Contributor

IMO this should be handled as a particular case. The OC Team is not a (single) regular user, but represents an entity. This link could be configured (for example using a variable in settings.inc.php) to define what it points to, such as a page describing OC Team and contact information.
This is different on a per installation basis, not per language.

@mzylowski
Copy link
Member

oc-team and System - both are used in oc code. Maybe just not create a link to profile if userid = 0 or -1 ?

@kojoty
Copy link
Member

kojoty commented Mar 29, 2017

in my opinion there should be a link to wiki article configured per node with oc-team description

@andrixnet
Copy link
Contributor

GPX export contains:

            if ($logtype == 'Post Reviewer Note') {
                $rLog['username'] = 'Centr.Obsl.Geocachera';
                $rLog['userid'] = '0';
            }

A similar resolution is needed here as well as in notification emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants