Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API for writing new visitors for the query parse tree is too complex #76

Open
pdowler opened this issue Aug 16, 2019 · 0 comments
Open

Comments

@pdowler
Copy link
Member

pdowler commented Aug 16, 2019

The top level navigator requires three separate components that visit different parts of the query (expressions, references, and from-items)... It might be much simpler to have a single monolithic Visitor that covers all the visit() methods even if that was a large number of methods.

Issues to consider:

  • re-use of navigator components is currently sketchy depending on whether they have/accumulate state or not
  • would be good to allow sub-select in the from clause, but that means recursion support (especially in the SelectListExtractor which has to percolate column metadata out to the top-level select)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant