event->trigger() speed profile

[zdanozdan]

What version of OpenCart are you reporting this for?
3+

Describe the bug
event->trigger() speed issue

system/engine
event->trigger() on profiler looks bad. It takes almost 30% of processing time on aggregate. There is foreach loop called zillion times, basically for every 2x model/view/controller/language. I changed this to simple array key access which improved processing times by factor of 2. Worth to take a look at it

Expected behavior
Use array access. Wildcard events needs to be redesigned though.

Screenshots / Screen recordings
If applicable, add screenshots or recordings to help explain your problem. Please keep these short and if you can, edit them to point out when/where the problem is.
https://www.useloom.com/ is perfect for screen recording with Chrome or with their desktop app

[TheCartpenter]

I covered similar subject long ago on this repository that new instances should not be loaded in a loop since it can normally load up a maximum of 300 classes overall during the loop. Events can get pretty vast, and rapidly, with time.

[zdanozdan]

I guess events can be real killer as processing time rise exponential in relation to number of events. The fix is fairly easy but wildcards are real pain to solve.

[danielkerr]

closing issue.

will look into later if people report problems once the extensions using events are in full swing.