Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to address the support for the upcoming PHP 8.2 #12074

Closed
mhcwebdesign opened this issue Dec 5, 2022 · 3 comments
Closed

Time to address the support for the upcoming PHP 8.2 #12074

mhcwebdesign opened this issue Dec 5, 2022 · 3 comments

Comments

@mhcwebdesign
Copy link
Collaborator

As per the header, PHP 8.2 support for OpenCart should be implemented soon for the upcoming PHP 8.2 release. We have created a pull request for the master branch for this: #12071

@danielkerr danielkerr reopened this Dec 9, 2022
@TheCartpenter
Copy link
Contributor

Integrated into opencart-3 now.

@mhcwebdesign
Copy link
Collaborator Author

Still some more fixes needed, see #12071 (comment) for details.

@mhcwebdesign
Copy link
Collaborator Author

mhcwebdesign commented Dec 22, 2022

Thanks for working on it, we are getting there.

There is just one outstanding issue with PHP8.2, for the system/library/mail/smtp.php, as follows:

Line 237:

				$results = str_split($line, 998);

needs to be replaced with:

				// see https://php.watch/versions/8.2/str_split-empty-string-empty-array
				$results = ($line === '') ? [''] : str_split($line, 998);

Otherwise the email text gets completely lost when using PHP8.2 !

tested on Linux Mint 20.3 with PHP 8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants