Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in modification.xml #1214

Closed
mhcwebdesign opened this issue Feb 15, 2014 · 1 comment
Closed

Bug in modification.xml #1214

mhcwebdesign opened this issue Feb 15, 2014 · 1 comment

Comments

@mhcwebdesign
Copy link
Collaborator

The 'modification.xml' should use this for modifying the 'system/engine/loader.php'

  <file name="system/engine/loader.php">
    <operation>
      <search>
        <![CDATA[include_once($file)]]>
      </search>
      <add position="replace">
        <![CDATA[include_once($this->modification->getFile($file))]]>
      </add>
    </operation>
    <operation>
      <search>
        <![CDATA[require($file)]]>
      </search>
      <add position="replace">
        <![CDATA[require($this->modification->getFile($file))]]>
      </add>
    </operation>
  </file>

The current content doesn't correctly modify the 'system/engine/loader.php' !

@danielkerr
Copy link
Member

fixed in latest commit. still working on it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants