Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language library has not been used rightly? #1809

Closed
edirpedro opened this issue Sep 5, 2014 · 0 comments
Closed

Language library has not been used rightly? #1809

edirpedro opened this issue Sep 5, 2014 · 0 comments

Comments

@edirpedro
Copy link

First I see that to point a text to use in template you set manually each key variable. But why if the language library does that when load a file?

This function load() has been used in a wrong way i think:
$this->language->load('account/login');

The right way would be:
$this->data = $this->language->load('account/login');

Now there is no need to set each key in controller:
$this->data['heading_title'] = $this->language->get('heading_title');

If i missed something here, probably Language library could be improved just a little bit to replace all that unnecessary code we have today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants