OC2: bug in admin/controller/extension/modification.php

[mhcwebdesign]

The file has a bug in function 'clear', when calling rsort($files). $files is not always set, causing rsort to fail with an error. Suggested fix:

    public function clear() {
        $this->load->language('extension/modification');

        $this->document->setTitle($this->language->get('heading_title'));

        $this->load->model('extension/modification');

        if ($this->validate()) {
            // Make path into an array
            $path = array(DIR_MODIFICATION . '*');
            $files = array();

            // While the path array is still populated keep looping through
            while (count($path) != 0) {
                $next = array_shift($path);

                foreach (glob($next) as $file) {
                    // If directory add to path array
                    if (is_dir($file)) {
                        $path[] = $file . '/*';
                    }

                    // Add the file to the files to be deleted array
                    $files[] = $file;
                }
            }

            // Reverse sort the file array
            rsort($files);
            .....

[skyosev]

All of the file removal logic can be trimmed down to three lines. See #1919

[danielkerr]

yes your right but i really hate that class. its very ugly class.