Rewards applied multiple times when changing order status

[jamesehly]

This is on OpenCart 2.0 official release

When a reward is set on a order, changing the order status applies the reward each time the status is changed. To reproduce:

1. set up a product that can be purchased with reward points
2. then add reward points to a customer.
3. login as the customer with reward points and purchase the item you created using your reward points
4. login to the admin interface and go to Sales > Orders
5. find your order and change it's status (either through the View screen or the Edit screen).
6. go to customer you created and see that the reward points have been added again.

Expected result is that reward points only get added once per order.

Here are some images to show you what is going on:

Order number 15 has had one status applied. So the intial order took off 650 reward points and then adding the 'Shipped' status has taken off another 650 points:

Here is the state of order number 15 before adding the complete status:

Here I am setting the order status to complete:

Now that the order is set to complete you can see that another 650 reward points is being taken off and that the customer now has -950 reward points.

I would expect that the rewards only get subtracted once per order and that a customer can never have negative reward points.

[danielkerr]

i think this has already been fixed ion the master branch

[jamesehly]

Confirmed, this is fixed in the master branch. It appears that the Processing Order Status setting affects the way rewards are processed. I have mine checked with Pending, Processing, Processed, and Shipped checked, and it now works as I expect it to.