New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCmod bug #2424
Comments
Here is my proposed bugfix for admin/controller/extension/modification.php:
|
I also came across another bug when using negative offsets for replace operations, as demonstrated by the OCmod-XML file below. With a replace-operation and a negative offset, the specified lines before the match, AND the matched line itself, should be replaced. I have updated my proposed bugfix in above post to take care of this issue, too.
|
As first reported on the OpenCart forum (http://forum.opencart.com/viewtopic.php?f=2&t=134922&p=530629#p530579). This OCmod-XML causes the additions to go into the wrong places, only the first instance ends up in the right place:
Tested on OpenCart 2.0.1.0 as well as the latest OpenCart 2.0.1.1.
It resulted in this wrong system/modification/admin/controller/catalog/product.php:
The text was updated successfully, but these errors were encountered: