Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode should be triggered when important modifications are missing #2647

Closed
tarranjones opened this issue Feb 5, 2015 · 3 comments

Comments

@tarranjones
Copy link

During modification refresh It is likeley on a high traffic site that a request or two will slip through before the refresh has completed.
I would prefer my users to see a custom maintenance page or a custom 404 rather than a distorted or less than functioning page.

//just before files are deleted, if config settings say maintenance mode is off then turn it on 

if(!$this->config->get('config_maintenance')){
    $this->load->model('setting/setting');
    $this->model_setting_setting->editSettingValue($code = 'config', $key = 'config_maintenance', $value = 1) ;
}

// Clear all modification files
....

....
    // Log
    $log[] = '----------------------------------------------------------------';                
}

//just after modifications are complete, if config settings say maintenance mode is off then turn it back off.

if(!$this->config->get('config_maintenance')){
    $this->model_setting_setting->editSettingValue($code = 'config', $key = 'config_maintenance', $value = 0) ;
}
// Log
$ocmod = new Log('ocmod.log'); 

 foreach ($xml as $xml) {
@danielkerr
Copy link
Member

very good point

@danielkerr
Copy link
Member

i'm assuming this was an issue for a site you have setup

@tarranjones
Copy link
Author

I believe it might be an issue when put into production.
The majority of the time when people click refresh will be to activate their newest uploaded modification.
Could we have a third action button in the modification list that allows the refresh of individual modifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants