Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method getTotalSales throws an exception when num_rows = 0 #2942

Closed
payoffice opened this issue Apr 23, 2015 · 1 comment
Closed

method getTotalSales throws an exception when num_rows = 0 #2942

payoffice opened this issue Apr 23, 2015 · 1 comment

Comments

@payoffice
Copy link

Hi everyone,
if I have no records in the order table, when I execute {Controller}->model_report_sale->getTotalSales()
an exception get thrown : "Undefined index: total".
I noticed that the method getTotalSales returns $query->row['total'].

Wouldn't it be better to return $query->row and test its value in the Controller ?

@payoffice
Copy link
Author

my baaaaad! ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant