-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong event name for new address and login trigger not working #3071
Comments
good work |
@vinyl919 why don't you share with us the trigger code? I might help us... |
catalog/model/account/address.php, line 4 is the PRE event, line 14 is the POST event, working ok on my tests. Pre events happen before data is modified / action is taken, post events happen after. |
Yes, the address trigger working fine. What I mean was that it is a mistake in documentation. Event name in file is "post.customer.add.address" and "pre.customer.add.address", but in documentation it is "post.customer.address.add" and "pre.customer.address.add". It is just a wrong order of words:) @madhurjain It is just code from line 10 of catalog/controller/account/login.php - "$this->event->trigger('pre.customer.login');" |
OK great, that's updated now in the docs. Thanks. |
I'm going to use a lot of triggers now, so maybe if I find any issues I will post them here. |
Hi,
Event name for add new address should be post.customer.add.address (catalog/model/account/address.php, line 4), not like given post.customer.address.add.
Also it seems that post.customer.login to not working properly. I've added trigger code in catalog/controller/account/login.php, line 55. Now it seems to work correctly. Before that it was not triggering any action.
The text was updated successfully, but these errors were encountered: