Bug in sale/order controller.

[hovi]

Hi,

in file admin/controller/sale/order.php, function api(), there are possible paths, that will result in variable $json not set - there is condition at around line 2176:

if (isset($this->session->data['cookie']) && isset($this->request->get['api'])) {

If condition does not apply, $json is never set and thus ajax request fails, because instead of json, result is PHP warning. I suggest adding else branch with setting $json to something, that at least give user hint about problem. I came across this, because I didn't have api user set up after upgrade and it was pain in the ass to find actual reason.

Cheers,

Karel Hovorka

[hovi]

Nevermind, I see master branch has this file completely refactored.