Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: E-Mail Message required! #438

Closed
estesasi opened this issue Feb 8, 2013 · 15 comments
Closed

Error: E-Mail Message required! #438

estesasi opened this issue Feb 8, 2013 · 15 comments

Comments

@estesasi
Copy link

estesasi commented Feb 8, 2013

When I try to send email to customers in the Admin control panel under Sales/Mail, I always get an error message "E-Mail Message required!" even though the message input field is not blank. However, the "contact us" contact form works fine. Order notification has no problem as well. Could anyone help me to fix this issue? I am using Opencart 1.5.5.1. Thanks!

@randixnet
Copy link

same error...

@opencart opencart closed this as completed Feb 9, 2013
@randixnet
Copy link

closed without comment about the problem ?

@DS-Matt
Copy link
Contributor

DS-Matt commented Feb 9, 2013

I have the same error in my OC v1.5.5.1, I think this might be a bug.

@opencart
Copy link
Collaborator

opencart commented Feb 9, 2013

have you tired the fix that has already been posted????????

@edtsz
Copy link

edtsz commented Apr 3, 2013

I got the same error with 1.5.5.1 version,
I Fixed it:

/* ***********
 * File: admin/view/template/sale/contact.tpl
 */
// adding:
$('textarea[name="message"]').val(CKEDITOR.instances.message.getData());
// before:
$('textarea[name=\'message\']').html($('textarea[name=\'message\']').val());

@choppingthought
Copy link

thanks edEr... U solved my problem

@scott-wyatt
Copy link

edEr, your fixed also solved this problem for me.

@imbossok
Copy link

imbossok commented Aug 2, 2013

thanks from me aswell, you would have thought this was fixed by now I just installed 1.5.6

@slightlyfaulty
Copy link
Contributor

Seems OC devs are only focusing on getting the next major version ready. It's a mystery they decided to release v1.5.6 in the first place, since it only adds a couple of useless extensions, but fixes no bugs.

EDIT
Thanks for the solution btw, @edEr-. You can, however, simply replace the existing line, instead of adding that new line after it. Not sure if this is what you meant, but just putting it out there.

@edtsz
Copy link

edtsz commented Aug 6, 2013

@saulfautley yep, your are right, also the OC devs already changed.

@jamesallsup jamesallsup reopened this Aug 7, 2013
@jamesallsup
Copy link
Contributor

@saulfautley - 1.5.6 extensions are only useless if you don't want to use them - are 99% of the extensions already in OpenCart useless too?, they are already being used by many merchants. Considering the PayPal Express module allowed for subscription payments finally its hardly useless.

I have re-opened the issue and will get a merge done as soon as possible for this fix on the 1.5.6 branch.

@edEr- thanks for the code suggestion, certainly helps when people chip in to suggest the fix.

@jamesallsup
Copy link
Contributor

Resolved

958f4f2

@slightlyfaulty
Copy link
Contributor

@jamesallsup, I certainly appreciate this issue being fixed. But I stand by my point that it is useless - if only relatively - to release a new version after half a year that only adds a few extensions, when there are numerous trivial issues that need to be fixed, most of which have been pending for months. Would the community not benefit more from finally getting these issues fixed, rather than adding a handful of extensions that some merchants/developers might use?

@ghost
Copy link

ghost commented Aug 7, 2013

@saulfautley
You may be interested in the unofficial OpenCart Community Edition fork where we're working to fix those bugs.

@slightlyfaulty
Copy link
Contributor

Thanks for the link, @OpencartHelp. This is really great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants