Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function getProductOptionValue name change on order.php -> getOptionValue #7890

Closed
exelaguilar opened this issue Apr 15, 2020 · 1 comment
Closed
Assignees

Comments

@exelaguilar
Copy link

What version of OpenCart are you reporting this for?
Master Branch

Describe the bug
A clear and concise description of what the bug is
What section does it affect?

The class name for getProductOptionValue has changed to getOptionValue so it throws a Proxy Error / Class not found when clicking on the packing slip button.

Packing Slip Invoices

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Sales > Orders'
  2. Click on 'View'
  3. Click on 'Print Packing Slip button'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots / Screen recordings
If applicable, add screenshots or recordings to help explain your problem. Please keep these short and if you can, edit them to point out when/where the problem is.
https://www.useloom.com/ is perfect for screen recording with Chrome or with their desktop app

Server / Test environment (please complete the following information):

  • Local development? Deployed to a web server?
  • Operating system
  • PHP version
  • Apache version
  • Browser(s) tested with [e.g. chrome, safari - if applicable]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

admin/controller/sale/order.php

Find in line 1792

$product_option_value_info = $this->model_catalog_product->getProductOptionValue($product['product_id'], $option['product_option_value_id']);

Replace with:

$product_option_value_info = $this->model_catalog_product->getOptionValue($product['product_id'], $option['product_option_value_id']);

@straightlight
Copy link
Contributor

Confirmed. The model convention name of getOptionValue has been renamed but the old convention name is still being called in the master branch from the addressed controller on the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants