Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/8/ilias 8 breaking changes #283

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [8.0.4]
- [FIX] this version fixes some incompatibilities with ILIAS 8.11. the
plugin can no longer be used with ILIAS 8.10 or older.

## [8.0.3]
- [FIX] Issue 266: Type casting in xoctUser
- [FIX] Issue 263: Type casting in metadata prefiller
Expand Down
4 changes: 2 additions & 2 deletions plugin.php
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php

$id = 'xoct';
$version = '8.0.3';
$version = '8.0.4';
$version_check = '44ac530093a998b525b0a73ba536e64f03bbaff47446cf99e1a31d6a042a4549';
$ilias_min_version = '8.0';
$ilias_min_version = '8.11';
$ilias_max_version = '8.999';
$responsible = 'Universität Bern';
$responsible_mail = 'david.graf@unibe.ch';
Expand Down
3 changes: 2 additions & 1 deletion src/UI/EventFormBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
use srag\Plugins\Opencast\Model\Metadata\MetadataField;
use srag\Plugins\Opencast\Model\Metadata\Definition\MDDataType;
use DateTimeZone;
use ILIAS\UI\Component\Input\Field\Section;

/**
* Responsible for creating forms to upload, schedule or edit an event.
Expand Down Expand Up @@ -293,7 +294,7 @@ public function update_scheduled(
);
}

private function buildTermsOfUseSection(): Input
private function buildTermsOfUseSection(): Section
{
return $this->ui_factory->input()->field()->section([
self::F_ACCEPT_EULA => $this->ui_factory->input()->field()->checkbox(
Expand Down
2 changes: 1 addition & 1 deletion src/UI/Form/ChunkedFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function getMaxFileSize(): int
return $this->max_file_size ?? -1;
}

protected function isClientSideValueOk($value): bool
public function isClientSideValueOk($value): bool
{
if (is_null($value)) {
return true;
Expand Down
4 changes: 3 additions & 1 deletion src/UI/Form/Loader.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use ILIAS\UI\Implementation\Component\Input\Field\ChunkedFile;
use ILIAS\UI\Implementation\Render\ComponentRenderer;
use ILIAS\UI\Implementation\Render\RendererFactory;
use ILIAS\Data\Factory;

/**
* Class Loader
Expand Down Expand Up @@ -41,7 +42,8 @@ public function getRendererFor(Component $component, array $contexts): Component
$this->dic["lng"],
$this->dic["ui.javascript_binding"],
$this->dic["refinery"],
$this->dic["ui.pathresolver"] ?? null
$this->dic["ui.pathresolver"] ?? null,
new Factory()
);
$renderer->registerResources($this->dic["ui.resource_registry"]);
$renderer->setPluginInstance($this->plugin);
Expand Down
2 changes: 2 additions & 0 deletions src/Util/UpdateCheck.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public function __construct(\ilDBInterface $db)

public function isUpdatePossible(): bool
{
return true; // we no longer check for compatibility, since there is no fork of the plugin anymore.
// Older versions
if (version_compare($this->last_update_version, '4.0.2', '<=')) {
return true;
Expand All @@ -61,6 +62,7 @@ public function isUpdatePossible(): bool

public function isNewInstallation(): bool
{
return false; // todo: check if this still possible
return $this->last_update_version === '0.0.0';
}
}