Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin interface creates invalid ACLs #352

Closed
lkiesow opened this issue May 7, 2024 · 0 comments · Fixed by #585
Closed

Admin interface creates invalid ACLs #352

lkiesow opened this issue May 7, 2024 · 0 comments · Fixed by #585
Assignees

Comments

@lkiesow
Copy link
Member

lkiesow commented May 7, 2024

…well, not strictly invalid but parts of them are unsupported and cause thousands of warnings in Opencast.

Uploading a video via the new admin interface you get a ton of errors like these:

2024-05-07 13:20:31,744 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write
2024-05-07 13:20:33,534 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write
2024-05-07 13:20:33,682 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write
2024-05-07 13:20:35,537 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write
2024-05-07 13:20:37,547 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write
2024-05-07 13:20:40,686 | INFO  | (EventIndexUtils:371) - Event index does not support denial via ACL, ignoring ROLE_ANONYMOUS is not allowed to write

It seems like some part of Opencast is adding denial rules. That part is the new admin interface.
This is what it is sending:

{
  "acl": {
    "ace": [
      {
        "action": "read",
        "allow": true,
        "role": "ROLE_ADMIN"
      },
      {
        "action": "write",
        "allow": true,
        "role": "ROLE_ADMIN"
      },
      {
        "action": "read",
        "allow": true,
        "role": "ROLE_ANONYMOUS"
      },
      {
        "action": "write",
        "allow": false,
        "role": "ROLE_ANONYMOUS"
      }
    ]
  }
}

This is what it should be sending:

{
  "acl": {
    "ace": [
      {
        "action": "read",
        "allow": true,
        "role": "ROLE_ADMIN"
      },
      {
        "action": "write",
        "allow": true,
        "role": "ROLE_ADMIN"
      },
      {
        "action": "read",
        "allow": true,
        "role": "ROLE_ANONYMOUS"
      }
    ]
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant