Set vite base #1297
Set vite base #1297
Conversation
|
This pull request is deployed at test.editor.opencast.org/1297/2024-03-18_11-38-54/ . |
geichelberger
force-pushed
the
vite-base
branch
from
d62c548
to
34d6f2f
Compare
|
This pull request is deployed at test.editor.opencast.org/1297/2024-03-18_15-16-04/ . |
|
Do you have any idea why the playwright tests are failing? |
|
Not really, no. I kinda hoped it would be chromium just having a hiccup or something, and that the test would work if I simply reran them the next day, but that does not seem to be the case. |
|
This pull request is deployed at test.editor.opencast.org/1297/2024-03-21_19-43-21/ . |
|
With my last commit, the playwright tests are working locally; there was a duration mismatch. The tests are using the develop instance, and I guess opencast/opencast#5669 changed the metadata 😄 |
|
Can confirm tests running locally (Quite unexpected to get an actual duration value in the metadata :D). Still running into timeouts in gh actions though. |
Vite does not honor the PUBLIC_URL environment variable; we need to set the base via that variable to support building versions with a path different from the root.
The metadata of the video used for the tests changed and caused a test case to fail.
|
This pull request is deployed at test.editor.opencast.org/1297/2024-04-03_13-30-09/ . |
|
Could it be caused by the problem that sometimes the i18n system is not loaded correctly?
|
|
This pull request is deployed at test.editor.opencast.org/1297/2024-04-03_17-31-29/ . |
|
This pull request is deployed at test.editor.opencast.org/1297/2024-04-03_18-51-07/ . |
|
However, that did not solve the problem with the playwright tests; it was caused by a problem with the constructed settings URL that needed to be corrected. |
Since the basepath is a relative path `./` by default, merging with the window location does not work. The location origin is http://localhost:5173 concatenated with the basepath `./`, and the settings path `editor-settings.toml` results in an invalid URL `http://localhost:5173./editor-settings.toml`
|
This pull request is deployed at test.editor.opencast.org/1297/2024-04-03_19-14-16/ . |
|
Amazing find! |
Vite does not honor the PUBLIC_URL environment variable; we need to set the base via that variable to support building versions with a path different from the root.