-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls to jump to next or previous segment #1317
Conversation
This pull request is deployed at test.editor.opencast.org/1317/2024-04-22_12-00-33/ . |
I found two problems with this:
opencast-editor-jump-segment.mp4 |
I agree with @lkiesow |
This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_09-14-05/ . |
I fixed the mentioned problems. to 1: I added a 3 second threshold at the beginning of the segment as it was not possible to jump back to the next video when the playback is active. For the duration, I oriented myself on spotify's "jump back" function.
I think we should change the wording too. Alternatively, we could provide a more general label like "Jump back" without explicitly mention the target. Especially with the treshhold, I'm not sure if your suggestion still fits. |
looks good to me now, Thanks @dennis531! As for the wording: I think a simple back/ forward might suffice. Users are already used to this wording with other media players. |
This pull request has conflicts ☹ |
Conflicts. :( |
Allow to jump when video player is playing. If current time is in the middle of the active segment, jump back to the beginning of this segment.
This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_12-25-11/ . |
This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_15-32-25/ . |
Looks good. I have a suggestion for a minor improvement for the 3 seconds threshold, but I'll file a separate pull request for that. |
Add the mentioned controls in #1283.
The controls are deactivated on the subtitle interface, as in my opinion the function is not needed here.
Screenshot with the controls: