Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

„Start Task“ selection highlighting is inconsistent #1908

Open
lkiesow opened this issue Oct 4, 2020 · 11 comments
Open

„Start Task“ selection highlighting is inconsistent #1908

lkiesow opened this issue Oct 4, 2020 · 11 comments
Labels
bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest javascript Pull requests that update Javascript code

Comments

@lkiesow
Copy link
Member

lkiesow commented Oct 4, 2020

  • Go to the admin interface
  • Select some events
  • Select Action → Start Task

Deactivating all selected events will cause Opencast to highlight at the selection blocks that some need to be checked.
If you deactivate the boxes one after another, this highlighting is inconstistent:

start-task-selection

The behavior should be consistent:

  • either always mark all checkboxes as to be selected one none are selected
  • or never highlight any boxes since the grayed out “Next” serves as indicator as well

Reproducible on Firefox 81.0.1- Likely caused by the required attributes of the checkboxes

Possibly related to #1907

@lkiesow lkiesow added bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest javascript Pull requests that update Javascript code labels Oct 4, 2020
@abhinavanand123
Copy link

Hello @lkiesow I'd like to give a try on this issue

@lkiesow
Copy link
Member Author

lkiesow commented Oct 4, 2020

To make your life easier, it seems like you can already reproduce this in the UI mockup without building and running all of Opencast:

% cd modules/admin-ui-frontend
% npm ci
% npm run build

@abhinavanand123
Copy link

Thank you @lkiesow
So basically all you need that the red color border on selection box shouldn't appear on it if you deactivate the boxes one after another also??

@lkiesow
Copy link
Member Author

lkiesow commented Oct 4, 2020

That's basically it. Or alternatively, show the requirement on all checkboxes.
If you want to dig a bit deeper, maybe you can take a look at #1907 as well

@abhinavanand123
Copy link

But I check it now I think currently it doesn't show the red border on it.

@lkiesow
Copy link
Member Author

lkiesow commented Oct 4, 2020

Testing again, it seems like the red border is specific to Firefox. It's probably the required attribute of the checkboxes.

@abhinavanand123
Copy link

Yes because it's working fine with chrome

@abhinavanand123
Copy link

So you want me to work on it so that it should be compatible for both the browsers.

@abhinavanand123
Copy link

sure working on it

@abhinavanand123
Copy link

@lkiesow can you help me out with the code of checkboxes i.e. where it is exactly, which folder shall I visit

@lkiesow
Copy link
Member Author

lkiesow commented Oct 5, 2020

The frontend lives in modules/admin-ui-frontend. Everything outside that folder should be irrelevant. The view should be app/scripts/shared/partials/modals/schedule-task-modal.html. Not sure about which JavaScript file is the corresponding JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants