Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-12746, Library Update #115

Merged
merged 1 commit into from Mar 6, 2018
Merged

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Mar 2, 2018

This patch updates several Java dependencies.

@staubesv staubesv self-assigned this Mar 5, 2018
@gregorydlogan gregorydlogan self-requested a review March 5, 2018 15:59
Copy link
Contributor

@staubesv staubesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a cosmetic issue (indentation, see comment).

Except that, seems to work.

<bundle>mvn:com.google.code.gson/gson/2.8.1</bundle>
<bundle>mvn:commons-collections/commons-collections/3.2.2</bundle>
<bundle>mvn:com.google.code.gson/gson/2.8.2</bundle>
<bundle>mvn:commons-collections/commons-collections/${commons-collection.version}</bundle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@gregorydlogan
Copy link
Member

Approved pending fix identified by @staubesv

This patch updates several Java dependencies.
@lkiesow
Copy link
Member Author

lkiesow commented Mar 5, 2018

Indentation fixed.

Copy link
Contributor

@staubesv staubesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@staubesv staubesv merged commit 1de21e8 into opencast:develop Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants