Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin UI systems filters should be accessible by the corresponding roles #1534

Merged

Conversation

wsmirnow
Copy link
Contributor

A non privileged admin UI user should may access jobs, services and servers filters by having the corresponding view roles.

Your pull request should…

  • have a concise title
  • close an accompanying issue if one exists
  • be against the correct branch (features can only go into develop)
  • include migration scripts and documentation, if appropriate
  • pass automated testing
  • have a clean commit history
  • have proper commit messages (title and body) for all commits
  • have appropriate tags applied

A non privileged admin UI user should may access jobs, services and servers filters by having the corresponding view roles.
@wsmirnow wsmirnow added bug ELAN Pull requests originating from ELAN e.V. labels Apr 21, 2020
@gregorydlogan gregorydlogan self-assigned this Apr 23, 2020
@gregorydlogan
Copy link
Member

This is kinda gimmicky, but what would be the expected set of minimum roles to view just these options? ROLE_ADMIN_UI plus the changes here? Because that leads to a broken UI. The test user is trapped on the events tab with the loading spinner, and no hamburger on the left to get to the other tabs...

@wsmirnow
Copy link
Contributor Author

You need the ROLE_UI_JOBS_VIEW to see especially the jobs tab. But if the user is not an global admin, the filters endpoint will be empty or hidden. Same for servers and services.
The minimum role set is:

  • ROLE_ADMIN_UI to generally see the admin UI parts
  • ROLE_UI_NAV to generally see the navigation menu
  • ROLE_UI_NAV_SYSTEMS_VIEW to see the systems icon/option in the navigation menu
  • ROLE_UI_JOBS_VIEW to see the jobs tab
  • ROLE_UI_SERVERS_VIEW to see the servers tab
  • ROLE_UI_SERVICES_VIEW to see the services tab

I've created an sample user on develop.opencast.org (username and password: systems-viewer) to test this scenario. There you can verify, that the filter pane isn't shown.

@gregorydlogan gregorydlogan merged commit 12d678a into opencast:r/8.x Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ELAN Pull requests originating from ELAN e.V.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants