Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1426, This fix changes the karma plugin to make the tests in safari. The issue with the former plugin was because of the security policies safari asks to open the file
redirect.html
, if you don't make this action the build fails.Using the
karma-safari-applescript-launcher
allows to comunicate with safari directly. The first time it will only ask in OSX if allows the terminal to run it. later builds it will not ask again.Your pull request should…
have a concise title
be against the correct branch (features can only go into develop)
pass automated testing
have a clean commit history
have proper commit messages (title and body) for all commits
have appropriate tags applied