Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Karma Safari test in mac OS #1539

Merged
merged 1 commit into from Apr 27, 2020

Conversation

mliradelc
Copy link
Contributor

@mliradelc mliradelc commented Apr 23, 2020

Follow up of #1426, This fix changes the karma plugin to make the tests in safari. The issue with the former plugin was because of the security policies safari asks to open the file redirect.html, if you don't make this action the build fails.

Screenshot 2020-04-23 at 08 43 27

Using the karma-safari-applescript-launcher allows to comunicate with safari directly. The first time it will only ask in OSX if allows the terminal to run it. later builds it will not ask again.

Your pull request should…

  • have a concise title

  • be against the correct branch (features can only go into develop)

  • pass automated testing

  • have a clean commit history

  • have proper commit messages (title and body) for all commits

  • have appropriate tags applied

@mliradelc mliradelc added bug maintenance This pull request is addressing maintenance issues labels Apr 23, 2020
@KatrinIhler
Copy link
Member

This is working for me, but I mean, I don't have a Mac, so... I bugged some of my colleagues, so I'll wait what they have to say.

@gregorydlogan
Copy link
Member

Works for me on my Debian box. Still worried about the buildbot stuff, but it works here so I don't think this is a blocker.

Copy link
Member

@KatrinIhler KatrinIhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rüdiger tested this with his Mac and says it works for him.
I'm still not happy that you have to confirm when you run the tests for the first time, but I guess it's better than before...

@KatrinIhler KatrinIhler merged commit 3582bd3 into opencast:r/7.x Apr 27, 2020
@gregorydlogan
Copy link
Member

There's also not a ton we can do about it unfortunately.

@mliradelc mliradelc deleted the t/fix-safari-test-admin-ui branch May 19, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maintenance This pull request is addressing maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants