MH-12934, Update translations #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lkiesow
commented
Jun 5, 2018
lkiesow
commented
- Update the translations to the current state on Crowdin.
- Add new languages: Filipino, Tagalog, Turkish
staubesv
suggested changes
Jun 6, 2018
There was a problem hiding this comment.
Hi @lkiesow
I've found two issues:
- Theodul Player needs likely to be adapted to support the new languages (see https://bitbucket.org/opencast-community/opencast/pull-requests/1792/mh-12515-add-language-support-for/diff#Lmodules/matterhorn-engage-theodul-core/src/main/resources/ui/js/engage/core.jsT184, for example)
- Changes to package-lock.json seem not related to this PR
modules/admin-ui/package-lock.json
Outdated
| "integrity": "sha1-0Hf2glVx+CEy+d/67Vh7QCn+/1c=", | ||
| "dev": true | ||
| }, | ||
| "abbrev": { | ||
| "version": "1.1.1", | ||
| "resolved": "https://nexus.opencast.org/nexus/content/repositories/npmjs/abbrev/-/abbrev-1.1.1.tgz", | ||
| "resolved": "http://nexus.opencast.org/nexus/content/repositories/npmjs/abbrev/-/abbrev-1.1.1.tgz", |
There was a problem hiding this comment.
Hi @lkiesow This change seems not related to updating translations. Why is it included in this PR?
- Update the translations to the current state on Crowdin. - Add new languages: Filipino, Tagalog, Turkish
lkiesow
force-pushed
the
t/mh-12934-update-translations
branch
from
83ab8e9
to
344bf4e
Compare
|
This updates the list of languages supported by the Theodul player.
lkiesow
force-pushed
the
t/mh-12934-update-translations
branch
from
344bf4e
to
5949385
Compare
staubesv
approved these changes
Jun 6, 2018
|
Hi @lkiesow Please note that I've merged this without waiting for CI to complete (was running for more than 2 hours). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.