Don't force inclusion of referred elements in snapshot #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a referred element should be excluded, but the reference has properties Opencast forces the element to stay in the snapshot. This changes the behaviour to the same as when no properties are set, i.e. the refered element will not be included in the snapshot when a user requests this. Fixes opencast#2627
mtneug
changed the title
|
@lkiesow: did you have time to look at this? |
|
Sorry, this completely slipped my mind. Will try getting it merged until the end of the week. |
lkiesow
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a referred element should be excluded, but the reference has
properties Opencast forces the element to stay in the snapshot. This
changes the behaviour to the same as when no properties are set, i.e.
the referred element will not be included in the snapshot when a user
requests this.
Fixes #2627
Your pull request should…