Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Plugin Loading #2881

Merged
merged 1 commit into from Aug 16, 2021
Merged

Player Plugin Loading #2881

merged 1 commit into from Aug 16, 2021

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jul 29, 2021

This patch switches to the OSGi annotations for the Theodul bundles,
fixing the problem that there were two plugin managers deployed in
Opencast by accident which caused all plugin to be loaded twice:

2021-07-29T02:01:27,286 | INFO  | (EngagePluginManagerImpl:156) - Installed Theodul plugin EngagePluginVideoVideoJS (static: 1/static REST: no)
2021-07-29T02:01:27,291 | INFO  | (EngagePluginManagerImpl:156) - Installed Theodul plugin EngagePluginVideoVideoJS (static: 2/static REST: no)
2021-07-29T02:01:27,292 | INFO  | (EngagePluginVideoVideojs:38) - Activated engage plugin: Videojs.

Your pull request should…

@lkiesow lkiesow added bug ELAN Pull requests originating from ELAN e.V. labels Jul 29, 2021
Copy link
Member

@mtneug mtneug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments on first round.

@mtneug mtneug self-assigned this Aug 10, 2021
This patch switches to the OSGi annotations for the Theodul bundles,
fixing the problem that there were two plugin managers deployed in
Opencast by accident which caused all plugin to be loaded twice:

    2021-07-29T02:01:27,286 | INFO  | (EngagePluginManagerImpl:156) - Installed Theodul plugin EngagePluginVideoVideoJS (static: 1/static REST: no)
    2021-07-29T02:01:27,291 | INFO  | (EngagePluginManagerImpl:156) - Installed Theodul plugin EngagePluginVideoVideoJS (static: 2/static REST: no)
    2021-07-29T02:01:27,292 | INFO  | (EngagePluginVideoVideojs:38) - Activated engage plugin: Videojs.
Copy link
Member

@mtneug mtneug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@mtneug mtneug merged commit 190b2d9 into opencast:r/10.x Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ELAN Pull requests originating from ELAN e.V.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants