MH-12538 Remove obsolete ACL distribution service and WOH distribute-acl #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staubesv
reviewed
Jan 15, 2018
| * @return Returns the attachment if possible or null. | ||
| */ | ||
| private Attachment getAclXmlAttachment(MediaPackage mediaPackage) { | ||
| Attachment[] aclAttachments = mediaPackage.getAttachments(new MediaPackageElementFlavor("text", "acl")); |
There was a problem hiding this comment.
The hard-coded flavor text/acl is very much the indication that all the distribute-acl stuff is obsolete
|
Hi @rrolf, thanks for taking the review! Note that I proposed the removal of the ACL distribution service quite a while ago on the developer list: https://groups.google.com/a/opencast.org/forum/#!searchin/dev/acl$20distribution$20service/dev/8cJ4vINNih4/t8YVZBoTDAAJ The proposal had passed. |
TurRil
referenced
this pull request
in TurRil/opencast
Mar 23, 2020
* OPENCAST-2803 - add logging to exception when creating new event * OPENCAST-2803 - remove log, add ".0" to presenter name * OPENCAST-2803 - check if has property presenter * OPENCAST-2803 - change presenter.0 to track_presenter.0
npmali
referenced
this pull request
in npmali/opencast
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting the original issue, this PR removes the ACL distribution service, as discussed here.
This work is sponsored by SWITCH.