No Elasticsearch Use In Ingest #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ingest service searches for series titles starting with pull request opencast#3586. This causes trouble when combined with the removal of the Solr index which now makes this code fall back to the Elasticsearch index instead. Unfortunately, the Elasticsearch modules are not included in the ingest distribution (opencast#3797) which will cause the distribution to fail. Simply including it works in theory, but causes trouble since our infrastructure documentation states that Elasticsearch may be available on the admin only and can thus, for example, be run with no encryption or authentication to make deployments easier. All this would need to change, making this quite messy. This patch fixes the issue by using a generated series identifier for which we need to full text search instead.
7 tasks
KatrinIhler
approved these changes
May 31, 2022
|
Seems to work, code looks good -> merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingest service searches for series titles starting with pull
request #3586. This causes trouble when combined with the removal of
the Solr index which now makes this code fall back to the Elasticsearch
index instead.
Unfortunately, the Elasticsearch modules are not included in the ingest
distribution (#3797) which will cause the distribution to fail.
Simply including it works in theory, but causes trouble since our
infrastructure documentation states that Elasticsearch may be available
on the admin only and can thus, for example, be run with no encryption
or authentication to make deployments easier. All this would need to
change, making this quite messy.
This patch fixes the issue by using a generated series identifier for
which we need to full text search instead.
This closes #3797
Your pull request should…