Make Delete Dialog Look Alike #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the issue that all three of Opencast's delete dialog (event, series, batch) do not look alike. This patch mostly adjust the event delete dialog to look like the series dialog. It now has one warning less, but the simpler structure adopted for visual clarity makes it hopefully clearer what is going on and easier to understand. Additionally, all three dialog now use a red “Delete” button to confirm the process instead of using “Confirm” at some places.
|
Thanks for the review → merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue that all three of Opencast's delete dialog
(event, series, batch) do not look alike.
This patch mostly adjust the event delete dialog to look like the series
dialog. It now has one warning less, but the simpler structure adopted
for visual clarity makes it hopefully clearer what is going on and easier
to understand.
Additionally, all three dialog now use a red “Delete” button to confirm
the process, instead of using “Confirm” at some places.
Your pull request should…