Allow deletion of reference users from the Admin UI #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External user providers will store users in the opencast database table `oc_user_refs`. However, external user providers may fail to remove users from Opencast when they should not exist anymore, and there is currently no easy way to remove users from that table (besides directly modifying the database). This can make it difficult for adopter to comply with data privacy policies. This commit adds deletion functionality to the `JpaUserReferenceProvider`, and allows deletion of users from other providers than "system" or "opencast", even if they are not "manageable" (which applies to all these users). It does not allow any changes beyond that, i.e. you may now delete a user created by an external provider, but you still can't change their name.
Arnei
added
enhancement
admin-ui-feature-tracking
|
We tested this, all looks good. |
|
Removing |
JulianKniephoff
removed
the
admin-ui-feature-tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4789
External user providers will store users in the opencast database table
oc_user_refs. However, external user providers may fail to remove users from Opencast when they should not exist anymore, and there is currently no easy way to remove users from that table (besides directly modifying the database). This can make it difficult for adopter to comply with data privacy policies.This commit adds deletion functionality to the
JpaUserReferenceProvider, and allows deletion of users from other providers than "system" or "opencast", even if they are not "manageable" (which applies to all these users). It does not allow any changes beyond that, i.e. you may now delete a user created by an external provider, but you still can't change their name.Your pull request should…
* [ ] include migration scripts and documentation, if appropriate