Upgrade Crowdin Integration #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydlogan
added
the
maintenance
gregorydlogan
commented
Jul 13, 2023
lkiesow
approved these changes
Aug 7, 2023
|
The very end of 13 may not have the most up to date translations if the api shutdown happens as scheduled. We discussed at the technical meeting and didn't feel this was a huge deal. I'm good with whatever branch this ends up in 🤷 |
lkiesow
added a commit
to lkiesow/opencast
that referenced
this pull request
Oct 2, 2023
Pull request opencast#5114 changed the Debian package downloaded to install the Crowdin client but failed to change the name of the package being installed. This patch fixes the problem and adjusts the package name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our Crowdin integration. The existing integration goes away towards the end of this year.
This PR also removes some files which are not present in the codebase. I'm unclear if we want to keep the first set, will raise a review.
Also unclear if we need to put this into
r/13.xor not. API sunset occurs prior to full r/13.x` support drop.Note: The relevant secret is already set in this repo's config. The old secret should be removed (IMO) after this PR has been merged.
Your pull request should…
close an accompanying issue if one existsinclude migration scripts and documentation, if appropriate