Disable auto refresh on feature installation

[JulianKniephoff]

Due to some wiring inconsistencies (and not all Opencast bundles being able to hot-restart properly) this currently breaks feature installation, because Karaf weants to refresh javax.persistence, which more or less everything depends on.

/cc #5151

[lkiesow]

What does this pull request do and why? You just described a problem of Opencast. How does disabling auto refresh on feature installations help, and what side effect does it have?

[JulianKniephoff]

Is there anything in particular that's unclear? Because I feel like most of your question is answered in the title and description: This PR disables Karaf's auto-refresh of bundles on feature installation, because said auto-refresh currently breaks Opencast when you install a feature. I would like to be able to install a feature (the Annotation Tool in particular, but that shouldn't matter), so disabling this would allow me to do so.

You can also skip auto-refresh using feature:install -r/--no-auto-refresh, but there is no way to skip it for features you drop into deploy, for example, which I would like to do. Plus: With the current settings you can't install features at all rn, so this is strictly an improvement, IMO. 🤷‍♀️

Side-note: Our plugin system is based on Karaf features, and lo and behold, the plugin manager does this as well.

As for the side-effects: That's fair. So what does auto-refresh even do? It rewires bundles, which you might want to do after a feature installation because the feature could contain new bundles/services/... that satisfy preexisting requirements. So the side-effect of this PR is obviously that this doesn't happen, which could lead to inconsistencies in your wiring, I think, but I'm not 100% sure. There is a whole swath of use cases where this does not apply, though. The Annotation Tool as an additional module that the rest of the system is completely agnostic of is one such example, apparently all of our plugins are, too.

And again, this strictly enables more stuff, only breaks in cases that didn't even work/exist before (if at all), and can be reverted if/when this is fixed in Karaf.

[lkiesow]

Huh, I wrote that plugin stuff 😁
But that doesn't mean I remember what Karaf's auto-refresh does.
Thanks for the explanation. That's what was missing for me.

[lkiesow]

Is this intended for develop? Or do you want this fix to go into a release branch?

[JulianKniephoff]

Fair. 😁 Sorry if that came across a bit salty. 🧂

Re. branch: For me personally it would be useful in the release branches as well, but this is a behavior changing config change, so I'm not sure if it's allowed to go in there? On the other hand, as said, the behavior it changes was broken to begin with, soooo ... 🤔🤷‍♀️?

[lkiesow]

Seems reasonable and seems to work.
I don't care about the branch.
I'll see where it ends up when I merge it after the technical meeting.

[JulianKniephoff]

In that case: Rebased on and retargeted to r/13.x. 😊👍

EDIT: The build fails due to the corrupted jar issue now, sadly. ☹️