Fix editing custom actions in the ACL editor #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
added
ELAN
Right now you can't edit custom actions of individual policies in the ACL editor; all the actions of all policies are kind of tied together. This is due to a bug in the JavaScript caused by the select component all operating on the same shared array. This PR fixes that bug by just making copies in appropriate places to break that link.
JulianKniephoff
force-pushed
the
fix-editing-acl-actions
branch
from
c01dd24
to
f1c5ba6
Compare
|
Requesting a review by @Arnei since he did the ACL editor overhaul. Of course I welcome any other reviewers as well! 😀 |
Arnei
approved these changes
Aug 14, 2023
|
I would try this with LDAP this week. Since the ACL UI overhaul has broken our installation, we are using an OC with the PR retracted. |
|
@mliradelc did you have a chance to look at this? Would be nice to get this in, soon. :) FWIW I doubt that the choice of LDAP over other methods of authentication has any bearing on this code. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now you can't edit custom actions of individual policies in the ACL editor; all the actions of all policies are kind of tied together.
This is due to a bug in the JavaScript caused by the select components all operating on the same shared array. This PR fixes that bug by just making copies in appropriate places to break that link.