Fix static file service exception on non-existing file #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the problem that the static file service throws an exception when requesting a non existing file instead of returning a proper `404 NOT FOUND` HTTP error code. This fixes opencast#5189
gregorydlogan
approved these changes
Sep 6, 2023
| } catch (Exception e) { | ||
| logger.warn("Unable to retrieve file with uuid {}", uuid, e); | ||
| return Response.serverError().build(); | ||
| } catch (NotFoundException | IOException e) { |
There was a problem hiding this comment.
I'm leery of returning a 404 on an IOException, but I guess without having more details of why we're seeing that exception this is a reasonable solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem that the static file service throws an exception when requesting a non existing file instead of returning a proper
404 NOT FOUNDHTTP error code.This fixes #5189
Your pull request should…