Don't take snapshot on asset upload before workflow #5247
Conversation
The workflow already takes a snapshot, and otherwise we can't figure out which assets are new.
KatrinIhler
added
ELAN
There was a problem hiding this comment.
Looks good and works as expected.
Since taking a snapshot at the beginning of the asset upload workflow still seems to be a good idea, would it make sense to add a comment on that to etc/event.upload.asset.options.propertires (or maybe in the docs, wherever it would make more sense)?
Also, the comment for startAddAssetWorkflow(JSONObject metadataJson, MediaPackage mediaPackage) talks at length about a race condition due to taking a snapshot prior to starting a workflow. Since that's not happening anymore, I suppose the potential race condition can't happen anymore either?
As we no longer take a snapshot before starting the workflow, and the workflow service checks for running workflows immediately before starting the workflow, this no longer applies.
|
@Arnei As we talked about, I will not document the need for a snapshot, as that's fairly obvious, but I did remove the comment about the race condition since it no longer applies. |
|
Approved and discussed, gonna merge this. |
In accordance with the recent changes to subtitles in Opencast, captions need special handling when they're uploaded to an existing event, e.g. they must be cut. This extends the existing workflow to handle this use case. **Attention:** This change depends on #5243 and #5247 to work and should not be merged separately! Also contains a minor fix in another workflow.
The workflow already takes a snapshot, and otherwise we can't figure out which assets are new in the workflow (which I need later).
This also actually makes the code a bit simpler.