Silence detection: Skip attaching smil file if empty #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geichelberger
changed the title
Under certain circumstances, for example, if the non-silent segments were smaller than the configured minimum voice length, the SMIL file contained no segments. This patch changes the behavior so the smil file won't be attached to the media package if it contains no segments. Signed-off-by: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
geichelberger
force-pushed
the
silence-detection
branch
from
439f62e
to
658284c
Compare
geichelberger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, for example, if the non-silent segments were smaller than the configured minimum voice length, the SMIL file contained no segments.
This patch changes the behavior so the smil file won't be attached to the media package if it contains no segments.