New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MH-13209, Put CAS Feature In Distributions #544
Conversation
This patch ensures that Opencast's CAS security feature is contained in all distributions and can easily be installed/enabled without enabling it by default or making it a core dependency.
It works @lkiesow. Now the But, why other authentication methods like ldap or shibboleth are in the core and loaded by default and CAS not? Should we create feature for each authentication method? |
Good point. I'll bring it up at tomorrows technical meeting. I think this is the better solution since it's easy to activate and has less code running by default. It would also be a good idea to do something like this for e.g. LDAP as well. But let's see what others think. |
Yes, I think so. |
I don't have CAS in place for testing but as @miesgre tested this and it looks fine for me, I'll accept the PR. |
This is an alternative to pull request opencast#795. The discussion on pull request opencast#795 is about wanting to put all optional features/modules into the Opencast core. Pull request opencast#543 was declined for exactly the reason that we wouldn't want to do that. If we decide to do this way after all, we should also accept the old pull request. This patch reverts pull request opencast#544 and applies the previously declined pull request opencast#543 instead. The pull request adds all of the CAS modules to Opencast's core feature, always starting those modules with Opencast, regardless of users needing the feature or not. This change has the advantage of making the feature slightly easier to configure as well as better tested since problems with those features will affect all installations.
This patch ensures that Opencast's CAS security feature is contained in
all distributions and can easily be installed/enabled without enabling
it by default or making it a core dependency.
This is an alternative solution to pull request #543