Update xmlsec version (CAS fix) #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
reviewed
Jan 14, 2024
| @@ -658,7 +658,7 @@ | |||
| <feature name="opencast-security-cas" version="${project.version}"> | |||
| <bundle start-level="82">mvn:commons-collections/commons-collections/3.2.1</bundle> | |||
| <bundle start-level="82">mvn:org.apache.velocity/velocity/1.7</bundle> | |||
| <bundle start-level="82">mvn:org.apache.santuario/xmlsec/2.1.2</bundle> | |||
| <bundle start-level="82">mvn:org.apache.santuario/xmlsec/2.2.6</bundle> | |||
There was a problem hiding this comment.
Looks reasonable. Does it make sense to define this as xmlsec.version in the main pom.xml like we do it with a lot of other libraries?
Lines 18 to 20 in 682fd48
The `xmlsec` dependency version did not match the version included in the `opencast-security-cas` feature.
geichelberger
force-pushed
the
update-xmlsec
branch
from
3e14180
to
c509b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xmlsecdependency version did not match the version included in theopencast-security-casfeature.