Don't duplicate user roles when switching ACL templates in old Admin UI #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatrinIhler
changed the title
|
Unable to reproduce this. UI looks fine, POST request too. |
Needs some more config to reproduce, details in private message. Sorry! |
|
Managed to reproduce the issue, unfortunately this PR did not fix it for me. |
|
(For anyone curious, the additional config Katrin mentioned is:
|
Arnei
approved these changes
Jan 26, 2024
|
Approved and discussed -> merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching templates in the ACL view of the old Admin UI of new events, series or ACL templates, the user roles are accidentally pushed twice. This is not visible in the UI, except if you have custom actions, which will result in them seeming to mysteriously multiply each time you select a different template:
This was initially broken by #5269.