Remove Paella 6 with OC 16 #5605
Conversation
gregorydlogan
added
the
maintenance
| @@ -35,15 +35,6 @@ jobs: | |||
| npm run eslint | |||
| git add package.json package-lock.json | |||
|
|
|||
| - name: update paella-player test libraries | |||
There was a problem hiding this comment.
There's no equivalent stanza here for paella 7. Should there be?
There was a problem hiding this comment.
There could be, but Dependabot will pick that up.
Would reduce the Dependabot pull requests though.
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
Also you did not catch all entries in the ´feature.xml` I think? |
|
Then there is also the config option to set either paella6 or 7, which is now obsolete? Even if we want to keep it around for the feature, we should not mention paella6 as a valid option. |
|
These rules can go as well, in theory. Maybe some adopters are doing redirect shenanigans that are relying on these rules. opencast/etc/security/mh_default_org.xml Line 290 in 5ddc5ad |
|
Otherwise I did some minimal testing to confirm that Paella7 still works (so we don't suddenly have zero working players). |
|
Think I got it all. The only thing I didn't see was more references in the feature.xml file - that's just paella 7 as far as I can tell. |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
This PR removes Paella 6 from Opencast, per the proposal on the users list
Your pull request should…
close an accompanying issue if one existsinclude migration scripts and documentation, if appropriate