Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-13432 Remove unused modals "Job Details" and "Server Details" #770

Merged
merged 1 commit into from Mar 13, 2019
Merged

MH-13432 Remove unused modals "Job Details" and "Server Details" #770

merged 1 commit into from Mar 13, 2019

Conversation

staubesv
Copy link
Contributor

The modals "Job details" and "Server details" are just mockups that are not in use.

The goal of this task is to remove them from the Opencast codebase.

@staubesv staubesv added the maintenance This pull request is addressing maintenance issues label Mar 12, 2019
@lkiesow lkiesow self-assigned this Mar 12, 2019
@lkiesow
Copy link
Member

lkiesow commented Mar 12, 2019

These are actually still referenced in the code though I guess that the references can just be removed as well:

.../admin-ui% grep -rn server-details-modal src
src/main/webapp/styles/views/modals/_modal-dialog.scss:26:    &#server-details-modal {
src/main/webapp/scripts/modules/systems/partials/serverActionsCell.html:1:<a data-open-modal="server-details-modal"
                                          
.../admin-ui% grep -rn job-details-modal src
src/main/webapp/scripts/modules/systems/partials/jobActionsCell.html:2:  data-open-modal="job-details-modal"

@staubesv
Copy link
Contributor Author

Good catch! Will update the PR tomorrow.

@staubesv
Copy link
Contributor Author

@lkiesow PR updated.

@lkiesow lkiesow merged commit 04ac10c into opencast:develop Mar 13, 2019
lkiesow added a commit that referenced this pull request Mar 13, 2019
…into develop

Pull request #770
  MH-13432 Remove unused modals "Job Details" and "Server Details"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This pull request is addressing maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants