Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add observability tests #13

Open
odeke-em opened this issue Nov 27, 2018 · 0 comments
Open

all: add observability tests #13

odeke-em opened this issue Nov 27, 2018 · 0 comments

Comments

@odeke-em
Copy link
Member

Reported offline by @johanbrandhorst, there is an issue whereby Prometheus trips out when a value isn't recorded. The issue is with the Prometheus Go exporter but was exacerbated by a missing tag value when recording MRoundtripLatencyMs in

mls = append(mls, observability.MRoundtripLatencyMs.M(observability.SinceInMilliseconds(dialStartTime)))

Test should be able to catch such problems but also to verify that we don't encounter missing tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant